[WIP] Translate JS to TS #1197
Draft
[WIP] Translate JS to TS #1197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `configs.ts`: Adds configuration handling for model loading and normalization - `env.ts`: Provides global environment configuration for the library - `utils/constants.ts`: Defines constant values used across the library - `utils/core.ts`: Implements core utility functions and types - `utils/data-structures.ts`: Introduces custom data structures like PriorityQueue - `utils/devices.ts`: Defines supported device types - `utils/hub.ts`: Adds utility functions for interacting with the Hugging Face Hub - `utils/maths.ts`: Provides mathematical processing utilities - `utils/tensor.ts`: Implements tensor manipulation and creation functions
- Introduces `dtypes.ts` with data type constants and mappings
- audio.ts - generic.ts
- image.ts
- ops/registry.ts
- generation/stopping_criteria.ts
|
Did it ever cross your mind that you just make beautiful JS unreadable with no gains and forcing everyone to install endless amounts of node_modules for... a PITA? Please learn modern JS, ESM and importmaps. |
|
This has been discussed in #1145 where the consensus was the same: TypeScript doesn't provide any additional benefits than what the library already does. |
- Implement `Processor` base class in `processing_utils.ts` for feature extraction - Add TypeScript type annotations to `streamers.ts` - Create `BeitFeatureExtractor` in `image_processing_beit.ts`
- Update `env.ts` to use `ICache` interface - Simplify import statements in `hub.ts` to use node: prefix - Improve type annotations in `onnx.ts` and `feature_extraction_utils.ts` - Add type definitions for cache and model JSON objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.