Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
reshape
for faster nested array constructiontolist
Fixes #1191
The reshape-based approach
The old implementation built the nested structure through a series of reshapes:
Each reshape step:
This results in substantial CPU time (multiple passes and callback dispatches) and memory churn (allocating and discarding intermediate arrays). The complexity effectively grows with both the number of elements and the number of dimensions.
Recursive construction with precomputed strides
The optimized version precomputes the strides—the number of elements to skip along each dimension—and builds the nested array recursively: