Skip to content

Conversation

amer-sinha
Copy link
Contributor

@amer-sinha amer-sinha commented Sep 3, 2025

What does this PR do?

adds the ability for Gemma2 models to run without post attention layer normalization and post feedforward layer normalization.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@amer-sinha amer-sinha force-pushed the gemma2-nopostnorm branch 7 times, most recently from 940ad76 to f8f3264 Compare September 3, 2025 23:35
Copy link
Contributor

github-actions bot commented Sep 3, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: gemma2, t5gemma

Copy link
Contributor

@vasqu vasqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any models that use this? We usually only support features that are already included in (to be) published models

@Cyrilvallez
Copy link
Member

Indeed! As @vasqu said, the best is to create a new model with modular (it will require very little code and efforts with modular)! 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants