Skip to content

Conversation

@albertvillanova
Copy link
Member

@albertvillanova albertvillanova commented Sep 9, 2025

CI hotfix: xfail test_training_with_transformers_paged for:

  • OnlineDPOTrainer
  • GRPOTrainerSlowTester

This PR marks tests as expected to fail for transformers < 4.56.2.

Changes:

Fix #4035.
Supersede and close #4043.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@kashif
Copy link
Collaborator

kashif commented Sep 9, 2025

we can also comment out the GRPO paged attention test as well... it also is "failing"

@albertvillanova
Copy link
Member Author

@kashif which test do you refer?

@kashif
Copy link
Collaborator

kashif commented Sep 9, 2025

@albertvillanova this one: https://github.com/huggingface/trl/blob/main/tests/slow/test_grpo_slow.py#L172

@kashif kashif self-requested a review September 9, 2025 13:28
@albertvillanova albertvillanova changed the title CI hotfix: xfail OnlineDPOTrainer test_training_with_transformers_paged CI hotfix: xfail test_training_with_transformers_paged Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI fails: ValueError: zero-size array to reduction operation maximum which has no identity

4 participants