fix: Send 200 code before sending index file or assets files #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugokernel
requested changes
Jun 10, 2024
| break | ||
| else: | ||
| # 3. Try to load index file | ||
| await write(request, "HTTP/1.1 200 OK\r\n\r\n") |
There was a problem hiding this comment.
send_file can raise HttpError and in this case status 404 would be sent after status 200
There was a problem hiding this comment.
In line 95-97:
if isinstance(handler, str):
await write(request, "HTTP/1.1 200 OK\r\n\r\n")
await send_file(request, handler)That might also cause this situation. Maybe this should also be changed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.