Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional text for stop sending variants. #165

Merged
merged 3 commits into from
Mar 21, 2022
Merged

Conversation

huitema
Copy link
Owner

@huitema huitema commented Mar 18, 2022

Addresses Martin Duke second ballot comment (Issue #153).
Addresses Robert Wilton's Stop Sending and DOQ_NO_ERROR comments (issue #150)

Comment on lines +394 to +397
request from the client before the client indicates the STREAM FIN. If the
server has not yet sent the response and indicated the STREAM FIN in the response
stream or already sent a RESET_STREAM, the server MUST issue a RESET_STREAM to
indicate that the transaction is abandoned.
Copy link
Collaborator

@saradickinson saradickinson Mar 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a re-wording suggestion to make the conditions clearer?

Suggested change
request from the client before the client indicates the STREAM FIN. If the
server has not yet sent the response and indicated the STREAM FIN in the response
stream or already sent a RESET_STREAM, the server MUST issue a RESET_STREAM to
indicate that the transaction is abandoned.
request from the client before the client indicates the STREAM FIN. The server MUST
issue a RESET_STREAM to indicate that the transaction is abandoned unless
* it has already done so for another reason or
* it has already both sent the response and indicated the STREAM FIN.

@saradickinson
Copy link
Collaborator

New error code and text on RESET look good - thanks.

We now have clear text on what the servers should do with the DNS transaction after getting a RESET, but Robert's query was to clarify what servers should so with the DNS transaction after receiving a STOP_SENDING. I was going to suggest using exactly the same text for the 2 scenarios but your comments about STOP_SENDING being indicative made me pause, so there is currently just a 'SHOULD NOT continue to process' suggestion. I'd like to align these two scenarios better if we can?

huitema and others added 2 commits March 21, 2022 08:17
@huitema
Copy link
Owner Author

huitema commented Mar 21, 2022

Yes, SHOULD NOT makes sense. The server side is not enforceable by the client. It may also not be realistic. By the time the server starts sending, the look up of cache, authoritative, etc., has already been done. Except in the zone transfer case, of course.

@huitema huitema merged commit c21cffe into master Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants