-
Notifications
You must be signed in to change notification settings - Fork 19
Move the bioauth OffenceSlasher from the runtime to its own pallet #1291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
be47f9c to
ce589b3
Compare
humanode-runtimehumanode-runtime
ce589b3 to
22d6aef
Compare
5927024 to
5414dc3
Compare
humanode-runtime63f3a67 to
ff0fb74
Compare
a5e12fd to
f2e2486
Compare
d19fe65 to
090e5cc
Compare
I haven't read the code just yet, but we don't want to do a synchronous deletion of the keys as it can exhaust the block size and fail. We need to first set up the facilities for making async collection of garbage, and then use them; or, alternatively, don't do it at the rumtime at all, and remove the keys manually instead via sudo txs - that I think can be done even today without any extra development. |
Got it, will remove the code related to deleting keys at the runtime level during runtime upgrade execution. |
4155df8 to
6ef1117
Compare
6ef1117 to
f7a553e
Compare
Closes #787