Skip to content

Conversation

@dmitrylavrenov
Copy link
Contributor

@dmitrylavrenov dmitrylavrenov commented Oct 9, 2024

Closes #787

@dmitrylavrenov dmitrylavrenov force-pushed the test-offence-slasher branch 5 times, most recently from be47f9c to ce589b3 Compare October 12, 2024 12:55
@dmitrylavrenov dmitrylavrenov changed the title Implement offence slasher logic test at humanode-runtime Introduce own offence handler logic at humanode-runtime Oct 12, 2024
@dmitrylavrenov dmitrylavrenov force-pushed the test-offence-slasher branch 4 times, most recently from 5927024 to 5414dc3 Compare October 24, 2024 17:26
@dmitrylavrenov dmitrylavrenov changed the title Introduce own offence handler logic at humanode-runtime Move the bioauth OffenceSlasher from the runtime to its own pallet Oct 24, 2024
@dmitrylavrenov dmitrylavrenov force-pushed the test-offence-slasher branch 4 times, most recently from 63f3a67 to ff0fb74 Compare October 24, 2024 18:24
@dmitrylavrenov dmitrylavrenov force-pushed the test-offence-slasher branch 2 times, most recently from a5e12fd to f2e2486 Compare November 12, 2024 12:54
@dmitrylavrenov dmitrylavrenov marked this pull request as ready for review November 12, 2024 13:16
@MOZGIII
Copy link
Contributor

MOZGIII commented Nov 13, 2024

2024-11-12 16:50:48 Removed 59778 Offences keys 🧹

I haven't read the code just yet, but we don't want to do a synchronous deletion of the keys as it can exhaust the block size and fail. We need to first set up the facilities for making async collection of garbage, and then use them; or, alternatively, don't do it at the rumtime at all, and remove the keys manually instead via sudo txs - that I think can be done even today without any extra development.

@dmitrylavrenov
Copy link
Contributor Author

2024-11-12 16:50:48 Removed 59778 Offences keys 🧹

I haven't read the code just yet, but we don't want to do a synchronous deletion of the keys as it can exhaust the block size and fail. We need to first set up the facilities for making async collection of garbage, and then use them; or, alternatively, don't do it at the rumtime at all, and remove the keys manually instead via sudo txs - that I think can be done even today without any extra development.

Got it, will remove the code related to deleting keys at the runtime level during runtime upgrade execution.

@dmitrylavrenov dmitrylavrenov added this pull request to the merge queue Nov 19, 2024
Merged via the queue into master with commit 59a98d4 Nov 19, 2024
21 checks passed
@dmitrylavrenov dmitrylavrenov deleted the test-offence-slasher branch November 19, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Move the bioauth OffenceSlasher from the runtime to its own pallet

4 participants