fix: implement AAR recommendations (threshold, dep floor, warnings, blog)#63
fix: implement AAR recommendations (threshold, dep floor, warnings, blog)#63hummbl-dev merged 1 commit intomainfrom
Conversation
1. Lower diff self-grade threshold 80→70 (addresses CI friction) 2. Add dep scoring floor at 20 (prevents misleading 0 for large dep counts) 4. Suppress SyntaxWarning in analyzer subprocess calls 8. Blog post draft: "We certified 170+ repos — governance is the bottleneck" Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
hummbl-dev
force-pushed
the
feat/claude/aar-recs
branch
from
4c606f5 to
0885196
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c606f5d00
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def _run_analysis(repo_path: Path, analyzers: list[Analyzer], exclude_paths: list[str] | None = None) -> list[Finding]: | ||
| """Run all analyzers against a repo.""" | ||
| # Suppress SyntaxWarning from escape sequences in scanned files | ||
| os.environ.setdefault("PYTHONWARNINGS", "ignore::SyntaxWarning") |
There was a problem hiding this comment.
_run_analysis now calls os.environ.setdefault(...), but src/arbiter/__main__.py does not import os, so any command path that reaches this function (e.g., analyze, score, diff) will raise NameError: name 'os' is not defined before analyzers run. This is a hard runtime failure in core CLI flows introduced by this change.
Useful? React with 👍 / 👎.
1 participant
Summary
4 AAR recommendations implemented:
Test plan
🤖 Generated with Claude Code