Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An bounds consistent propagator for all_different #164

Merged
merged 33 commits into from
Mar 24, 2025

Conversation

Dekker1
Copy link
Contributor

@Dekker1 Dekker1 commented Mar 21, 2025

Implementation thanks to @dannem1337

A few TODOs left before merging:

  • Bounds consistency seems like the same default. Is that correct? (It at least reduces the number of variables we generally make equality literals for). Chuffed, I believe, uses both bounds and value consistency at the same time
  • @AllenZzw mentioned an issue when testing.

dannem1337 and others added 30 commits January 21, 2025 16:58
….rs to comply with the latest changes in huub
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 92.87469% with 29 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/huub/src/constraints/int_all_different.rs 96.01% 11 Missing and 4 partials ⚠️
crates/huub/src/flatzinc.rs 53.57% 11 Missing and 2 partials ⚠️
crates/huub/src/lib.rs 66.66% 0 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
crates/huub/src/lib.rs 67.72% <66.66%> (-0.62%) ⬇️
crates/huub/src/flatzinc.rs 48.62% <53.57%> (+0.15%) ⬆️
crates/huub/src/constraints/int_all_different.rs 95.38% <96.01%> (+0.85%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

codspeed-hq bot commented Mar 21, 2025

CodSpeed Performance Report

Merging #164 will degrade performances by 30.66%

Comparing Dekker1:feat/all_different_bounds (900e2fa) with develop (be40788)

Summary

❌ 1 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
satisfaction[sudoku_p48] 9.5 ms 13.6 ms -30.66%

@Dekker1 Dekker1 marked this pull request as ready for review March 24, 2025 05:26
@Dekker1 Dekker1 merged commit 63b9288 into huub-solver:develop Mar 24, 2025
10 of 11 checks passed
@Dekker1 Dekker1 deleted the feat/all_different_bounds branch March 24, 2025 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants