Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce integer reasoning when checking reasons in debug mode #167

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

Dekker1
Copy link
Contributor

@Dekker1 Dekker1 commented Mar 28, 2025

This reintroduces functionality removed in 73f966b. The
problematic behaviour that changes of search order between debug and release builds is resolved by
ensuring the propagation queue remains unchanged while checking the reasons.

Copy link

codecov bot commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 91.52542% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/huub/src/solver/engine.rs 92.98% 4 Missing ⚠️
crates/fzn-huub/src/trace.rs 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
crates/huub/src/lib.rs 67.61% <100.00%> (-0.11%) ⬇️
crates/fzn-huub/src/trace.rs 44.33% <0.00%> (-0.53%) ⬇️
crates/huub/src/solver/engine.rs 80.49% <92.98%> (+0.49%) ⬆️

... and 15 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

codspeed-hq bot commented Mar 28, 2025

CodSpeed Performance Report

Merging #167 will not alter performance

Comparing Dekker1:fix/reason_check (c0e6800) with develop (02d3bf5)

Summary

✅ 14 untouched benchmarks

@Dekker1 Dekker1 force-pushed the fix/reason_check branch 2 times, most recently from e0ff3c2 to b0f6fd5 Compare March 31, 2025 02:26
@Dekker1 Dekker1 force-pushed the fix/reason_check branch from b0f6fd5 to 9a264d6 Compare April 7, 2025 05:58
This ensures all reasoning of (integer) consequences has already
been performed by the SAT solver.
@Dekker1 Dekker1 force-pushed the fix/reason_check branch from 9a264d6 to c0e6800 Compare April 7, 2025 06:08
@Dekker1 Dekker1 marked this pull request as ready for review April 7, 2025 06:37
@Dekker1 Dekker1 merged commit c0e6800 into huub-solver:develop Apr 7, 2025
11 checks passed
@Dekker1 Dekker1 deleted the fix/reason_check branch April 7, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant