Feedback on WF and SF syntax #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Consistent subscript on `SF` and `WF` - Troubleshooting hints for accidentally redefining them in TLA+ (which I tried to do while learning)
|
I am obscenely behind, sorry, but I haven't forgotten this |
hwayne
reviewed
Nov 11, 2022
hwayne
requested changes
Nov 11, 2022
There was a problem hiding this comment.
Good changes! Two requests:
- In line (365) it should still be
Next]_varsbecause it's a direct translation from pluscal. - I'd like to see the spec you wrote that produced the error you included troubleshooting for, just to better understand what went wrong there. Doesn't have to be included in the actual manual, feel free to just attach it in a PR comment.
docs/core/tla.rst
Outdated
| or | ||
| Encountered "SF_" at line X, column Y | ||
|
|
||
| It's because you try to redefine operator ``WF_var(A)`` or ``SF_var(A)`` whereas they are already taken keywords. |
There was a problem hiding this comment.
Could you provide the spec that you got that caused error to appear?
There was a problem hiding this comment.
yes, sorry for the late reply. Has been occupied by work. Will try to update this PR this week. <>[PR updated this week]
There was a problem hiding this comment.
This is a little artificial, but there might be cases where developers accidentally declaring some variables or expression whose name start with WF_ or SF_, without realizing its collision with keywords.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SFandWF