Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Major refactor of gamepad handling system, replacing polling-based state management with an event-driven approach for improved performance and reduced CPU usage.
- Removed legacy polling initialization from
src/pages/_app.tsxin favor of event-based state management - Implemented state diffing in
src/services/gamepad.service.tsto prevent unnecessary updates - Added stateChangeCallbacks system in gamepad service for efficient state propagation
- Streamlined
src/stores/gamepad.store.tsby removing unused fields and implementing caching for connected gamepads - Modified
src/hooks/use-gamepad.hook.tsto use store-provided service access instead of direct singleton usage
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
chubbygrannychaser
requested changes
Jun 7, 2025
src/hooks/use-gamepad.hook.ts
Outdated
| getButtonValue: (button: GamepadButtonType) => number; | ||
| getAxisValue: (axis: GamepadAxisType) => number; | ||
| vibrate: (options: GamepadVibrationOptions) => void; | ||
| connectedGamepads: Array<{ index: number; name: string; layout: string }>; |
There was a problem hiding this comment.
Use { index: number; name: string; layout: string }[] here instead
src/hooks/use-gamepad.hook.ts
Outdated
| const service = getService(); | ||
| const { | ||
| duration = 200, | ||
| weakMagnitude = 0.5, |
There was a problem hiding this comment.
Could you please move these magic numbers to constants? EX const DEFAULT_WEAK_MAGNITUDE or something more descriptive
chubbygrannychaser
approved these changes
Jun 7, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.