Skip to content

feat: add a copy link button#1886

Open
marcosandreeo wants to merge 14 commits intohydralauncher:mainfrom
marcosandreeo:main
Open

feat: add a copy link button#1886
marcosandreeo wants to merge 14 commits intohydralauncher:mainfrom
marcosandreeo:main

Conversation

@marcosandreeo
Copy link
Copy Markdown

When submitting this pull request, I confirm the following (please check the boxes):

  • I have read the Hydra documentation.
  • I have checked that there are no duplicate pull requests related to this request.
  • I have considered, and confirm that this submission is valuable to others.
  • I accept that this submission may not be used and the pull request may be closed at the discretion of the maintainers.

Fill in the PR content:

Added a "Copy download link" button below the Download button that simply copies the download link to allow the user to use it however it wants. For example, when using torrents, the user can copy the magnet link and use it in any torrent client application.

Screenshot From 2025-12-01 09-16-11

@sonarqubecloud
Copy link
Copy Markdown

@padthai37
Copy link
Copy Markdown

This is a super useful feature that I'd love to see in the project, but it looks like it's pretty far behind master. Do you want to replay it over the latest master? Or I can do it (but I didn't want to claim ownership for your work)

@felipeaguiarn
Copy link
Copy Markdown
Contributor

This is an excellent addition; it would be nice to check it out and update it to better align with the main version.

@marcosandreeo marcosandreeo reopened this Mar 5, 2026
@marcosandreeo
Copy link
Copy Markdown
Author

This is a super useful feature that I'd love to see in the project, but it looks like it's pretty far behind master. Do you want to replay it over the latest master? Or I can do it (but I didn't want to claim ownership for your work)

Thanks, I merged the latest master into it, I think it should be ok now.

@marcosandreeo marcosandreeo reopened this Mar 5, 2026
@padthai37
Copy link
Copy Markdown

Excellent work! Looks like you just need to get a review from someone with write access as build passed 1hr ago

@sonarqubecloud
Copy link
Copy Markdown

@padthai37
Copy link
Copy Markdown

padthai37 commented Mar 21, 2026

This is another great feature lingering in the codebase (thanks @marcosandreeo!), unfortunately falling out of sync after each release. What does it take to get these changes merged?

Github isn't suggested reviewers are doesn't provide the ability to find users with write access but from what I can tell some of the people who have previously approved PRs are @chubbygrannychaser @zamitto @Moyasee. Perhaps someone can help out here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants