Conversation
… English, Portuguese, and Russian
…raction to clarify default behavior
…me download payload types
… GameFilesManager
…maticallyDeleteArchiveFiles parameter
…wnloadSettingsModal and RepacksModal, and update related user preferences in SettingsContextDownloads
…tails component for enhanced download handling
| seedAfterDownloadComplete: false, | ||
| showDownloadSpeedInMegabytes: false, | ||
| extractFilesByDefault: true, | ||
| extractFilesByDefault: false, |
There was a problem hiding this comment.
Changing extractFilesByDefault from true to false looks like a product/default-behavior change, not just part of the archive deletion feature. Was that intended for this PR, or should it be split out?
There was a problem hiding this comment.
That change wasn't intended for this PR. It was left over from a local behavior test I was running. I'll revert it.
| userPreferences.showDownloadSpeedInMegabytes ?? false | ||
| ) | ||
| : "", | ||
| deleteArchiveFilesAfterExtractionByDefault: |
There was a problem hiding this comment.
I want to double-check the persistence path after the rename to deleteArchiveFilesAfterExtractionByDefault. Can we confirm this new key is saved/read consistently everywhere and that existing users won’t silently lose their previous preference?
There was a problem hiding this comment.
Here are two screenshots from DevTools showing the userPreferences object in LevelDB with deleteArchiveFilesAfterExtractionByDefault
The key is being persisted and read back correctly. No data loss for existing users since this is a new key
…roved user experience
…into feat/LBX-650
|
3 participants
When submitting this pull request, I confirm the following (please check the boxes):
Fill in the PR content: