added some functionalities for ungaged catchments #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Zeitsperre
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Looks good to me, but I'm no expert here. Maybe wait on @RondeauG's approval as well.
Any easy way of adding a simple test for this?
RondeauG
approved these changes
Nov 29, 2024
TC-FF
commented
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
What kind of change does this PR introduce?
uncertainities.calc_q_iter function did not work for ungaged catchemnts as L1 could not be used and you had to select a specific catchment. Added 'all' option for catchment and L1 specification.