Major refactoring of sampled_indicators #240
Open
+423
−299
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
sampled_indicators
was too memory-inefficient for bigger applications and could quickly grow to 10s or even 100s of Gb of RAM. Thus, the function has been split in two to allow for writing the results of the sampling on disk and offload some of the RAM usage. No miracle can be done, but this should be slightly better.include_dims
, instead of being automatic. The dimensionstime
andhorizon
are still never sampled._weighted_sampling
was almost completely rewritten to hopefully make better use of chunks and multithreading throughdask
.Does this PR introduce a breaking change?
sampled_indicators
, from the inputs required to the outputs produced.Other information: