Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to the climate change notebooks #279

Merged
merged 12 commits into from
Mar 31, 2025
Merged

Improvements to the climate change notebooks #279

merged 12 commits into from
Mar 31, 2025

Conversation

RondeauG
Copy link
Collaborator

@RondeauG RondeauG commented Mar 24, 2025 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Various improvements to the climate change notebooks.

Does this PR introduce a breaking change?

Other information:

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@RondeauG RondeauG requested review from TC-FF and lou-a March 24, 2025 20:54
@github-actions github-actions bot added notebooks Run tests against notebooks docs labels Mar 24, 2025
@RondeauG RondeauG changed the title cc notebooks Improvements to the climate change notebooks Mar 24, 2025
Base automatically changed from notebook_xhfa to better_doc March 28, 2025 17:16
Base automatically changed from better_doc to main March 28, 2025 23:22
lou-a
lou-a approved these changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@lou-a lou-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just added some minor comments for edits to clarify the text in the 2 notebooks.

@github-actions github-actions bot added the approved Approved for additional tests label Mar 31, 2025
@RondeauG RondeauG merged commit ada4a99 into main Mar 31, 2025
17 checks passed
@RondeauG RondeauG deleted the notebooks_grg branch March 31, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lou-a lou-a lou-a approved these changes

@TC-FF TC-FF Awaiting requested review from TC-FF

Assignees
No one assigned
Labels
approved Approved for additional tests docs notebooks Run tests against notebooks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RondeauG @lou-a