This repository was archived by the owner on Jun 3, 2021. It is now read-only.
Docker-Widget #126
Open
Docker-Widget #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 18 alerts when merging 4f92224 into 7dd398b - view on LGTM.com new alerts:
|
|
This pull request introduces 18 alerts when merging 48b0e49 into 346fff7 - view on LGTM.com new alerts:
|
|
@prash897 please fix the build errors as well as lgtm violations as raised above |
|
@rvema Please update |
|
@prash897 we will get this looked into |
|
This pull request introduces 18 alerts when merging fcb47fd into 87cb03a - view on LGTM.com new alerts:
|
|
@prash897 please address the issues raised by lgtm and do fix the build failures. |
|
@prash897 did you get a chance to address the review comments? |
|
@prash897 fix lint errors and update the branch with master |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker (Change Release Details)
Is this a Change or Addition: An Addition
What has been added : A Widget on dashboard view page.
What kind of Widget : A widget to support the docker collector details
What is included in Widget: Card Chart , Bar and line chart, IClickDetails to show the docker details like the Containers, CPU USages, Networks details.
What files has been changed : Two core files
shared.module : The Component classes are imported and added as declarations & entry components
dashboard-view: An entry is made for docker collector as Infrastrucre as code
Docker : The folder and the chart components are added as seperate class componets and they are imported in docker-widget.component
The above is added as a widget folder to widgets folder
How the code is organized : As a rule the config form and widget component are pretty much doing the same as expected.
Do we have a seperate collector created to support the widget :
Yes we have created a docker collector : https://github.com/Hygieia/hygieia-docker-collector
An enum as "Docker" is added to hygieia-core