use REFERENCE_WALLET for get_stats simulations#39
Merged
Conversation
…ions Simulation-only methods like get_stats() were failing with "Return data not found" when clients were created with new_random_keypair(), because the random pubkey doesn't exist on-chain. This uses the existing build_simulation_transaction pattern with REFERENCE_WALLET (already designated for simulation use) to decouple the fee payer from the client's keypair.
hylevi
changed the title
hylevi
changed the title
0xPlish
approved these changes
Jan 30, 2026
Contributor
0xPlish
left a comment
0xPlish
left a comment
There was a problem hiding this comment.
No issues here, but I just realized - can't we just use the ProtocolStateStrategy's underlying ExchangeContext to get xSOL NAV?
We can -- this was just a bonus bugfix. I think this fn wasn't generally being called. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_stats() was failing with "Return data not found" when using new_random_keypair() because the random pubkey doesn't exist on-chain.
Now uses REFERENCE_WALLET as the simulation fee payer.