Skip to content

Conversation

@georgezgeorgez
Copy link

"github.com/golang/protobuf/proto" is deprecated
in favor of "google.golang.org/protobuf/proto"

Most changes are from re-generated proto classes

"github.com/golang/protobuf/proto" is deprecated
in favor of "google.golang.org/protobuf/proto"

Most changes are from re-generated proto classes
@georgezgeorgez
Copy link
Author

Generated with

protoc -I. --go_out=:. --go_opt=paths=source_relative common/types/protobuf.proto
protoc -I. --go_out=:. --go_opt=paths=source_relative chain/nom/protobuf.proto
protoc -I. --go_out=:. --go_opt=paths=source_relative consensus/storage/election_data.proto
protoc -I. --go_out=:. --go_opt=paths=source_relative consensus/storage/point.proto

@sol-znn
Copy link

sol-znn commented Sep 28, 2023

I can confirm the generated protobuf files match the ones in the PR.
How did you test them?

@georgezgeorgez
Copy link
Author

i built the binary and just starting syncing the node
should probably do a more thorough test before merging the upstream PR

Copy link

@sol-znn sol-znn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do some client testing when your testnet is updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants