Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: boilerplate code for app context operation verifier #5366

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

ameten
Copy link
Contributor

@ameten ameten commented Feb 4, 2025

Description

Clarify Reprepare reason for Hyperlane Application Context

If application context indicates that a Hyperlane message was being delivered as part of warp route, we make more verifications depending on the chain so that we can differentiate between error of estimating gas for the delivery and messages which does not conform the rules applied to a warp route. We change the reprepare reason for non-conforming messages so that we can differentiate such events in metrics.

Drive-by changes

  • Minor refactoring

Related issues

Backward compatibility

Yes

Testing

Manual since application specific checks are not part of CI

Copy link

changeset-bot bot commented Feb 4, 2025

⚠️ No Changeset found

Latest commit: 8c5f178

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ameten ameten changed the title Boilerplate code for app context operation verifier feat: boilerplate code for app context operation verifier Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (dc0fe6c) to head (8c5f178).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5366   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

1 participant