-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support intents #392
base: main
Are you sure you want to change the base?
Conversation
@fernandomg is attempting to deploy a commit to the Abacus Works Team on Vercel. A member of the Team first needs to authorize it. |
src/consts/warpRoutes.ts
Outdated
tokens: [], | ||
tokens: [ | ||
{ | ||
addressOrDenom: ITT, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in warpcore, addressOrDenom
is actually the router and collateralOrDenom
would be the token contract, curious why you had to deviate here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this comes from the initial approach (and the currently running patched intent's framework UI) and how the gas/allowances/balances were calculated.
So, if I set the ROUTER
in addressOrDenom
I get the error: "Connected token not found..."
And IIUC I shouldn't be setting the connected
tokens to point to the ROUTER
address, instead of ITT
.
I'll re-check docs and code to see if I'm missing something
Also, allow to pass `fillDeadline` for intent creation
A draft to showcase the intent support in the UI using
CoreProxy
to allow interfacing withIntentCore
orWarpCore
based on the token standard.This is a WIP, a lot of types are not properly set and still requires fine tunings
/cc @nambrot