fix(build): publish Maven artifacts under hyperledger-identus namespace - #19
Closed
patextreme wants to merge 1 commit into
Closed
fix(build): publish Maven artifacts under hyperledger-identus namespace#19patextreme wants to merge 1 commit into
patextreme wants to merge 1 commit into
Conversation
Follow-up to #18. The sbt release process runs `publishArtifacts`, which uses sbt-github-packages to publish the jar+POM to `maven.pkg.github.com/<githubOwner>/<githubRepository>`. These were still pointing at the legacy `hyperledger` / `identus-keycloak-plugins` repo, which is orphaned (404), so the release aborted there: [publish] java.io.FileNotFoundException: https://maven.pkg.github.com/hyperledger/identus-keycloak-plugins/.../0.2.1/identus-keycloak-oid4vci-0.2.1.pom Point them at the current repo (`hyperledger-identus`/`keycloak-plugins`) so the publish (and thus the docker image push that follows it in the release) can complete. Signed-off-by: Pat Losoponkul <patextreme@hotmail.com>
Contributor
Author
|
Superseded — going with option C: stop publishing the Maven jar entirely (nothing consumes it; only the Docker image is needed). The githubOwner/githubRepository namespace is then moot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to #18 (which migrated the Docker image namespace). The first release run after #18 (run 30343777327) failed — semantic-release computed `0.2.1` correctly, but `sbt release`'s `publishArtifacts` step 404'd while publishing the jar+POM:
```
[publish] java.io.FileNotFoundException:
https://maven.pkg.github.com/hyperledger/identus-keycloak-plugins/.../0.2.1/identus-keycloak-oid4vci-0.2.1.pom
```
sbt-github-packagespublishes to `maven.pkg.github.com//`, and those were still the legacy `hyperledger`/`identus-keycloak-plugins` — the same orphaned namespace as the Docker image.Fix
Point `githubOwner`/`githubRepository` at the current repo (`hyperledger-identus`/`keycloak-plugins`), so the Maven publish — and the Docker image push that follows it in the same release — can complete.
No release/tag was created by the failed run (semantic-release is transactional; `version.sbt` is still `0.2.0-SNAPSHOT`), so re-running `release.yml` after this merge will still cut 0.2.1.
Notes for reviewer