chore(build): stop publishing Maven artifacts; release only the Docker image - #20
Merged
Conversation
…r image The plugin jar has no Maven consumer anywhere in the Identus workspace (it is consumed exclusively via the Docker image, which COPYs it from target/). Publishing it to GitHub Packages only caused problems: - the sbt-github-packages target (maven.pkg.github.com/hyperledger/ identus-keycloak-plugins) was orphaned from the repo and 404'd, aborting the release before the Docker image push; - GitHub Packages is also inconsistent with the workspace convention, where libraries (apollo, vdr, mediator) publish to Maven Central under org.hyperledger.identus. Drop the Maven-publish plumbing entirely: - remove `publishArtifacts` from the release process; - remove the now-unused `commonSettings` (githubOwner/githubRepository); - remove the sbt-github-packages plugin. The jar is still built (`packageBin` remains in the release process) so the Dockerfile-ci `COPY ./target/*.jar` still works; only the Maven publish step is gone. Signed-off-by: Pat Losoponkul <patextreme@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Following the namespace-consistency check: the plugin jar published to GitHub Packages has no Maven consumer anywhere in the Identus workspace — it's consumed only via the Docker image (which `COPY`s it from `target/`). Publishing it only caused problems:
Change
Drop the Maven-publish plumbing entirely:
The jar is still built (`packageBin` stays in the release process) so `Dockerfile-ci`'s `COPY ./target/*.jar` still works — only the Maven publish step is gone. After this, the release just: builds the jar → builds & pushes the Docker image to `ghcr.io/hyperledger-identus/keycloak-plugins` (from #18) → cuts the tag.
Release flow (after merge)
Re-trigger `release.yml` → semantic-release cuts 0.2.1 (#18's `fix:` commit is already on `main`) and publishes only the Docker image. Then set the new GHCR package public, verify `docker pull`, and bump cloud-agent's image reference.
Notes for reviewer