perf(core)!: optimise interop with crypto wasm #248
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rc
insidePublicKey
andPrivateKey
to make cloning cheaperBytesJs
, duplicate methods for bytes input and hex input (e.g.from_raw
andfrom_raw_hex
). Experiments showed this is faster._hex
getters (e.g. leave onlypayload
, removepayload_hex
). Experiments showed that getting data always as bytes and then optionally "hexing" it is faster than getting hex and then optionally "dehexing" it.Misc:
VerifyResult
fromSignature.verify()
; just throw plain errors.Closes #241
Benchmarks are confusing. Depending on the order of benches in the file,
prev
ornext
could be faster. In other words, this PR doesn't bring a noticeable change. But the source code on the Rust side is clearer now and maybe it will indeed work faster in some cases.