-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prep82 update bindings #119
Merged
ggwpez
merged 6 commits into
hyperledger-labs:dev
from
perun-network:prep82-update-bindings
Jun 24, 2021
Merged
Prep82 update bindings #119
ggwpez
merged 6 commits into
hyperledger-labs:dev
from
perun-network:prep82-update-bindings
Jun 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draft until contracts are reviewed and merged |
07b1755
to
2b8652f
Compare
ggwpez
suggested changes
Jun 23, 2021
2b8652f
to
099703c
Compare
Force push minor fixups. |
099703c
to
8ee8992
Compare
Force push update bindings to merged contract version. Leaving PR draft mode. |
In preparation for virtual channels. Signed-off-by: Matthias Geihs <[email protected]>
Signed-off-by: Matthias Geihs <[email protected]>
Signed-off-by: Matthias Geihs <[email protected]>
Also includes a bug fix for the following. Method Register was not returning an error when the contract call failed. This made it hard to detect if something went wrong. Now register errors if the register contract call errors. Signed-off-by: Matthias Geihs <[email protected]>
Signed-off-by: Matthias Geihs <[email protected]>
Signed-off-by: Matthias Geihs <[email protected]>
8ee8992
to
c2f7f4e
Compare
force push rebase |
sebastianst
approved these changes
Jun 24, 2021
ggwpez
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split some more commits from #83 .
In particular, this PR includes the following: