Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep82 update bindings #119

Merged
merged 6 commits into from
Jun 24, 2021

Conversation

matthiasgeihs
Copy link
Contributor

Split some more commits from #83 .

In particular, this PR includes the following:

  • Update contract bindings
  • Adopt channel data types
  • registerRecursive

@matthiasgeihs matthiasgeihs marked this pull request as draft June 22, 2021 15:47
@matthiasgeihs
Copy link
Contributor Author

draft until contracts are reviewed and merged

channel/allocation.go Show resolved Hide resolved
backend/ethereum/channel/conclude_test.go Outdated Show resolved Hide resolved
backend/ethereum/channel/conclude_test.go Show resolved Hide resolved
channel/adjudicator.go Show resolved Hide resolved
backend/ethereum/channel/backend.go Show resolved Hide resolved
backend/ethereum/channel/register_test.go Show resolved Hide resolved
client/adjudicate.go Outdated Show resolved Hide resolved
@matthiasgeihs matthiasgeihs force-pushed the prep82-update-bindings branch from 2b8652f to 099703c Compare June 24, 2021 06:50
@matthiasgeihs
Copy link
Contributor Author

Force push minor fixups.

@matthiasgeihs matthiasgeihs force-pushed the prep82-update-bindings branch from 099703c to 8ee8992 Compare June 24, 2021 06:59
@matthiasgeihs
Copy link
Contributor Author

Force push update bindings to merged contract version. Leaving PR draft mode.

@matthiasgeihs matthiasgeihs marked this pull request as ready for review June 24, 2021 07:01
@ggwpez ggwpez self-requested a review June 24, 2021 08:27
In preparation for virtual channels.

Signed-off-by: Matthias Geihs <[email protected]>
Also includes a bug fix for the following.
Method Register was not returning an error when the contract call failed.
This made it hard to detect if something went wrong.
Now register errors if the register contract call errors.

Signed-off-by: Matthias Geihs <[email protected]>
@matthiasgeihs matthiasgeihs force-pushed the prep82-update-bindings branch from 8ee8992 to c2f7f4e Compare June 24, 2021 09:59
@matthiasgeihs
Copy link
Contributor Author

force push rebase

@ggwpez ggwpez merged commit ea432b1 into hyperledger-labs:dev Jun 24, 2021
@matthiasgeihs matthiasgeihs deleted the prep82-update-bindings branch September 14, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants