Add anchor peer enhancement: Using SDK #126
Conversation
Signed-off-by: n0s09by <[email protected]>
Signed-off-by: n0s09by <[email protected]>
nidhi-singh02
force-pushed
the
anchorAPI
branch
from
0984d62 to
1e5c478
Compare
| log.warn( | ||
| "Network, User and MSP details cannot be NULL: " | ||
| + "Network = " | ||
| + network |
There was a problem hiding this comment.
Aren't these null? Would it help if we concatenate null to log messages?
There was a problem hiding this comment.
Not all of these (network, user and msp details) would be null at the same time. The intention is if any of these are null and others are not null, the log messages will help us in knowing which value is not present, which would help us in debugging.
| ErrorCode.HYPERLEDGER_FABRIC_CONNECTION_ERROR, | ||
| "Error while establishing connection to the gateway", | ||
| } catch (Exception e) { | ||
| log.warn("Error while channel configuration update : " + e.getMessage()); |
There was a problem hiding this comment.
Use standard log4j formatting instead of concatenating ythe string.
For eg: This should be written as log.warn("Error while channel configuration update with error message : {}", e.getMessage);
There was a problem hiding this comment.
Thanks, I see string concatenation being used at other places as well, I have changed it to log4j formatting in the files where this PR changes are present. We can pick up refactoring to ensure logging format is consistent throughout the data connector, currently it is mixed.
Signed-off-by: n0s09by <[email protected]>
nidhi-singh02
force-pushed
the
anchorAPI
branch
from
1e5c478 to
936e536
Compare
No description provided.