Skip to content

listTransferMethods not handling response as a list #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ukrarome wants to merge 1 commit into
base: master
Choose a base branch
from
Open

listTransferMethods not handling response as a list #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hyperwallet/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3144,7 +3144,7 @@ def listTransferMethods(self,
params
)

return TransferMethod(response)
return [TransferMethod(x) for x in response.get('data', [])]

'''

Expand Down
9 changes: 5 additions & 4 deletions hyperwallet/tests/test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2652,6 +2652,7 @@ def test_list_webhooks_success(self, mock_get):
Upload Documents

'''

def test_uploadDocumentsForUser_fail_need_user_token(self):

with self.assertRaises(HyperwalletException) as exc:
Expand Down Expand Up @@ -2963,18 +2964,18 @@ def test_list_transfer_methods_fail_need_params_invalid(self):
def test_list_transfer_methods_params_valid(self, mock_get):

options = {'type': 'test'}
mock_get.return_value = self.data
mock_get.return_value = {'data': [self.data]}
response = self.api.listTransferMethods('token', options)

self.assertTrue(response.token, self.data.get('token'))
self.assertTrue(response[0].token, self.data.get('token'))

@mock.patch('hyperwallet.utils.ApiClient._makeRequest')
def test_list_transfer_methods_success(self, mock_get):

mock_get.return_value = self.data
mock_get.return_value = {'data': [self.data]}
response = self.api.listTransferMethods('token')

self.assertTrue(response.token, self.data.get('token'))
self.assertTrue(response[0].token, self.data.get('token'))


if __name__ == '__main__':
Expand Down