Skip to content

Add ORCID client service #9565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

Add ORCID client service #9565

merged 1 commit into from
May 15, 2025

Conversation

mtomilov
Copy link
Contributor

@mtomilov mtomilov commented May 9, 2025 •
edited
Loading

Refs #9561
Refs #9487

Here we have the ORCID client service which is a thin layer helping us to send responses to authorization server and receive responses from it.

@mtomilov mtomilov marked this pull request as draft May 9, 2025 14:38
@mtomilov mtomilov closed this May 9, 2025
@mtomilov mtomilov reopened this May 9, 2025
@mtomilov mtomilov force-pushed the add-orcid-client-service branch from d18f145 to d79a28f Compare May 12, 2025 10:48
@mtomilov mtomilov marked this pull request as ready for review May 12, 2025 10:48
@mtomilov mtomilov changed the base branch from main to add-openid-client-service May 12, 2025 10:48
@mtomilov mtomilov force-pushed the add-orcid-client-service branch 4 times, most recently from b52543e to 88a8129 Compare May 12, 2025 11:25
@mtomilov mtomilov requested a review from seanh May 12, 2025 13:46
@mtomilov mtomilov force-pushed the add-orcid-client-service branch from 88a8129 to e75df1a Compare May 12, 2025 14:12
seanh
seanh approved these changes May 13, 2025
View reviewed changes
Copy link
Member

@seanh seanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this all looks pretty clean, no notes 👍

@mtomilov mtomilov force-pushed the add-openid-client-service branch from 531e9e3 to c6fd601 Compare May 14, 2025 11:15
Base automatically changed from add-openid-client-service to main May 14, 2025 11:18
@mtomilov mtomilov force-pushed the add-orcid-client-service branch from e75df1a to d38cc4e Compare May 14, 2025 11:32
@mtomilov mtomilov force-pushed the add-orcid-client-service branch from d38cc4e to bda7361 Compare May 15, 2025 07:13
@mtomilov mtomilov merged commit 552678b into main May 15, 2025
11 checks passed
@mtomilov mtomilov deleted the add-orcid-client-service branch May 15, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanh seanh seanh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtomilov @seanh