Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak affecting ext+e interpolation in AMG #1243

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix memory leak affecting ext+e interpolation in AMG #1243

wants to merge 2 commits into from

Conversation

victorapm
Copy link
Contributor

This PR includes a memory leak fix to the hypre_BoomerAMGBuildModExtPEInterpHost function. The change adds a call to free the dof_func_offd memory.

@victorapm victorapm requested a review from rfalgout March 7, 2025 16:44
rfalgout
rfalgout approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@rfalgout rfalgout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Victor! Do we need to add a run to our regression tests to ensure this gets tested with valgrind? I assume we weren't doing any runs before that used this particular code path.

@victorapm
Copy link
Contributor Author

Hi Rob, yes, that's a good idea. Let me do it

@victorapm
Copy link
Contributor Author

@rfalgout I've added a regression test for case showing the leak (interptype 18) and also for other interpolation types just for completeness.

@waynemitchell could you generate the baselines in aurora? I don't have access

@victorapm victorapm mentioned this pull request Mar 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfalgout rfalgout rfalgout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@victorapm @rfalgout