Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update all dependencies, and update rollup build #31

Merged
merged 5 commits into from
Feb 10, 2021

Conversation

cellog
Copy link
Contributor

@cellog cellog commented Feb 9, 2021

A few big changes

  • package-lock.json should definitely be included in the repo
  • intl-messageformat should be a peer dep
  • using new rollup, the umd/amd/iife builds are all generated in 1 build step.
  • the newest intl-messageformat uses Intl's built-in locales, so no more locale loading. This is the reason I bumped to 2.0.0
  • formatted the test with prettier, and re-organized the number format one to be a bit more readable

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • documentation is changed or added

BREAKING CHANGE: internally, addLocaleData is no longer used.
@cellog
Copy link
Contributor Author

cellog commented Feb 9, 2021

fixes #30

@cellog
Copy link
Contributor Author

cellog commented Feb 9, 2021

@jamuhl it looks like travis is in a perpetual hang - the config probably needs to be updated to use Precise instead of xenial (can't do that in the PR)

@jamuhl jamuhl merged commit ba6d54f into i18next:master Feb 10, 2021
@jamuhl
Copy link
Member

jamuhl commented Feb 10, 2021

Thank you for putting this all together and contributing.

Was published in [email protected]

@cellog cellog deleted the update-everything branch February 14, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants