Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding function to parse language for ICU to address #35 #63

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Adding function to parse language for ICU to address #35 #63

merged 2 commits into from
Apr 3, 2023

Conversation

karoun
Copy link
Contributor

@karoun karoun commented Apr 2, 2023

  • See title; addresses Map i18next language code to ICU locale #35
  • Adds parseLngForICU function that runs prior to IntlMessageFormat construction
  • Allows use of pseudo-locales like zz-ZZ or treating one locale like another for purposes of ICU

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided
  • commit message and code follows the Developer's Certification of Origin

@karoun karoun mentioned this pull request Apr 2, 2023
Closed
@adrai adrai merged commit 9615bc9 into i18next:master Apr 3, 2023
@adrai
Copy link
Member

adrai commented Apr 3, 2023

thank you for your contribution...
it has been released with v2.3.0

@karoun karoun deleted the karoun/parse-lng branch April 3, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karoun @adrai