refactor: switch to tsc esm build#12
Conversation
Summary of ChangesHello @iHildy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the project's build infrastructure by transitioning from a Bun-centric build process to a standard TypeScript compiler (tsc) workflow for producing ES modules. This change aims to simplify the build pipeline, enhance compatibility with modern JavaScript environments, and standardize module resolution by updating all internal imports to use Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the build process to use tsc for generating ES modules. This is a good step towards modernizing the project's build pipeline. The changes are consistent across the codebase, with build scripts, TypeScript configuration, and import paths all updated to support the new ESM-based build. I've noticed one critical configuration issue in tsconfig.build.json that needs to be addressed. Apart from that, the refactoring is well-executed.
🤖 Review Jules RelayI found 1 Gemini suggestion so far. Type |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Summary
Merges refactor that switches the project build to tsc for an ES module (ESM) build, updates imports to use .js extensions, and adjusts config and metadata accordingly.
Changes
Testing
mise run buildorbun run build) and verify a newdist/directory appearsmise run testorbun test) to confirm no regressionssrc/commandis copied todist/commandas before