Non generic repos #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 18, 2015 14:01
…ype implements IAggregate
…mary class; dropped generic event frame and snapshot classes
Owner
|
Related to #13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are building a framework that requires aggregate repositories without type parameters. In order to achieve this, I updated the aggregate repository classes to be based on IAggregate and removed the type parameters for several internal classes (snapshot, memento, event frame families). There are still aggregate repository classes with type-specific interfaces, but they are now adapters instead of the actual implementations.
I attempted to keep the public interfaces intact, but a few interface changes were necessary. I don't believe consumers of this library will need to change code to implement the update.
The casting I've introduced should be safe and hidden from library consumers.
I believe that the use of object for Id introduces a negligible amount of boxing when value types are used for aggregate Ids. While I haven't completely analyzed this, the existing use of JSON serializers was already boxing Ids.