Update outdated npm dependencies #51
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, JSON parsing errors were only logged to console but tests still reported as passing. Now parsing errors are properly reported as test failures with descriptive error messages, and the tool exits with code 1 when JSON-LD is malformed. - Add __detectJsonLdErrors() helper to scan HTML for malformed JSON-LD - Modify structuredDataTestHtml() to detect JSON parsing errors before validation - Modify _structuredDataTest() to add parsing errors as failed tests - Add comprehensive test suite for malformed JSON-LD handling - Test valid JSON-LD processing even when invalid JSON-LD is present
Updated all outdated dependencies to their latest CommonJS-compatible versions: **Updated to latest:** - columnify: 1.5.4 → 1.6.0 - csvtojson: 2.0.10 → 2.0.13 - jmespath: 0.15.0 → 0.16.0 - validator: 11.0.0 → 13.15.20 - yargs: 13.2.4 → 18.0.0 - husky: 3.0.1 → 9.1.7 - jest: 25.1.0 → 30.2.0 - jest-fetch-mock: 2.1.2 → 3.0.3 - pkg: 4.4.7 → 5.8.1 **Updated to last CommonJS version:** Several packages have moved to ESM-only in their latest versions. Since this project uses CommonJS (require/module.exports), we've updated these to their last CommonJS-compatible versions: - chalk: 2.4.2 → 4.1.2 (v5+ is ESM-only) - get-stream: 5.1.0 → 6.0.1 (v7+ is ESM-only) - is-stream: 2.0.0 → 2.0.1 (v3+ is ESM-only) - node-fetch: 2.6.0 → 2.7.0 (v3+ is ESM-only) All tests pass successfully with the updated dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates all outdated npm dependencies to their latest CommonJS-compatible versions. All tests pass successfully.
Changes
Updated to latest versions:
Updated to last CommonJS version:
Several packages have moved to ESM-only (ES modules) in their latest versions. Since this project uses CommonJS (
require/module.exports), these packages were updated to their last CommonJS-compatible versions:Discussion
To upgrade to the latest versions of chalk, get-stream, is-stream, and node-fetch, the project would need to be converted from CommonJS to ESM, which would be a breaking change for consumers of this library. This PR takes the conservative approach of staying on CommonJS while still updating to the latest compatible versions.
If there's interest in migrating to ESM in the future, that would allow upgrading these packages to their latest versions (chalk 5.x, get-stream 9.x, is-stream 4.x, node-fetch 3.x).
Testing
All existing tests pass:
Note
Husky 9.x has a different configuration approach than v3. The git hooks configuration in
package.jsonmay need to be migrated to the new format in a follow-up PR if git hooks are actively used.