Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct dayjs.extend's return type #1666

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

melusc
Copy link

@melusc melusc commented Oct 14, 2021

dayjs.extend returns dayjs (lowercase d), not Dayjs.

This means TypeScript allows chaining extend calls like dayjs.extend(...).extend(...) instead of having to do dayjs.extend(...); dayjs.extend(...).

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f0c9a41) 99.77% compared to head (0690a4d) 100.00%.

❗ Current head 0690a4d differs from pull request most recent head c9ab4f3. Consider uploading reports for the commit c9ab4f3 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #1666      +/-   ##
===========================================
+ Coverage   99.77%   100.00%   +0.22%     
===========================================
  Files         183       179       -4     
  Lines        2262      1996     -266     
  Branches      641       507     -134     
===========================================
- Hits         2257      1996     -261     
+ Misses          5         0       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@melusc melusc changed the title fix: Correct dayjs.extend's return type fix: Correct dayjs.extend's return type Feb 28, 2022
@melusc
Copy link
Author

melusc commented Feb 17, 2024

@iamkun

Not to bother you, but is there anything keeping this simple change from being merged? Just cause it's been open for two years now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant