Skip to content

fix: verify published package exports#23

Merged
ianalloway merged 1 commit into
mainfrom
fix/verify-dist-exports
Jul 7, 2026
Merged

fix: verify published package exports#23
ianalloway merged 1 commit into
mainfrom
fix/verify-dist-exports

Conversation

@ianalloway

Copy link
Copy Markdown
Owner

Summary

  • Refreshes generated dist artifacts so the package entrypoint exports the public APIs already present in src/index.ts.
  • Adds a dist verification smoke test that compares exported source functions against dist/index.js and dist/index.d.ts.
  • Documents lint, Jest, and dist verification commands in the README.

Test Plan

  • npm run lint
  • npm test -- --runInBand
  • npm run test:dist
  • npm run prepublishOnly

Copilot AI review requested due to automatic review settings June 30, 2026 14:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ede103ad9e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread dist/index.js
Comment on lines +725 to +727
winProb: round4(winProb),
drawProb: round4(drawProb),
lossProb: round4(lossProb),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Normalize Poisson outcome probabilities

When callers use a mean that leaves non-trivial mass above maxGoals (for example poissonModel(5, 5) with the default 10), these returned probabilities are raw truncated sums, so winProb + drawProb + lossProb is 0.9728 instead of 1 and the derived fair odds are biased. Please either include/renormalize the tail probability or validate/choose maxGoals from the supplied lambdas before returning the probabilities.

Useful? React with 👍 / 👎.

@ianalloway
ianalloway merged commit 69d9c96 into main Jul 7, 2026
4 checks passed
@ianalloway
ianalloway deleted the fix/verify-dist-exports branch July 7, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants