fix: verify published package exports#23
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ede103ad9e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| winProb: round4(winProb), | ||
| drawProb: round4(drawProb), | ||
| lossProb: round4(lossProb), |
There was a problem hiding this comment.
Normalize Poisson outcome probabilities
When callers use a mean that leaves non-trivial mass above maxGoals (for example poissonModel(5, 5) with the default 10), these returned probabilities are raw truncated sums, so winProb + drawProb + lossProb is 0.9728 instead of 1 and the derived fair odds are biased. Please either include/renormalize the tail probability or validate/choose maxGoals from the supplied lambdas before returning the probabilities.
Useful? React with 👍 / 👎.
Summary
Test Plan