chore: ship only dist/ in the npm tarball#29
Merged
Conversation
Without a `files` field (and with no .npmignore), npm fell back to .gitignore and published the default set — the full src/ including the 47KB test suite, tsconfig, jest config, scripts/, and .github/. A consumer of @ianalloway/kelly-js has no use for any of it. Add `"files": ["dist"]` so the published tarball is dist/ plus the files npm always includes (README, LICENSE, package.json): 7 files instead of 24. No behavior change; dist/ was already included, this just drops the cruft. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
"files": ["dist"]to package.json sonpm publishships a clean tarball.Why
With no
filesfield and no.npmignore, npm fell back to.gitignoreand published the default set — the entiresrc/(including the 47KBindex.test.ts),tsconfig*.json,jest.config.js,scripts/, and.github/. None of that belongs in a consumer'snode_modules.Effect
npm pack --dry-run: 24 files → 7 (dist/ + README + LICENSE + package.json, which npm always includes).dist/was already shipping, so this only drops cruft — no behavior change.Verified:
npm run buildclean, 148 tests pass, tarball inspected.🤖 Generated with Claude Code