Skip to content

Prevent dashboard chat from loading private MEMORY.md#57

Open
ianalloway wants to merge 1 commit into
mainfrom
codex/propose-fix-for-dashboard-chat-vulnerability
Open

Prevent dashboard chat from loading private MEMORY.md#57
ianalloway wants to merge 1 commit into
mainfrom
codex/propose-fix-for-dashboard-chat-vulnerability

Conversation

@ianalloway

Copy link
Copy Markdown
Owner

Motivation

  • The dashboard channel was classified as a private/main session and therefore received MEMORY.md in the LLM system prompt, which exposed operator long-term memory to unauthenticated /api/chat requests.

Description

  • Remove "dashboard" from the private/main channel tuple in build_chat_system_prompt so dashboard chat uses the shared prompt path and does not include MEMORY.md.
  • Update the function docstring to clarify that only authenticated private channels receive memory.
  • Add a regression test test_dashboard_chat_uses_shared_prompt_without_memory in tests/test_workspace.py that verifies CLI still gets memory but dashboard does not.

Testing

  • Ran python -m pytest tests/test_workspace.py tests/test_dashboard_chat.py tests/test_server.py and all relevant tests passed (7 passed, 3 skipped).

Codex Task

Copilot AI review requested due to automatic review settings July 14, 2026 18:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants