Sanitize dashboard/status to prevent leaking brief contents#58
Open
ianalloway wants to merge 1 commit into
Open
Sanitize dashboard/status to prevent leaking brief contents#58ianalloway wants to merge 1 commit into
ianalloway wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
data/reports/*.mdand embedding them into the status payload and rendered JS, bypassing the HMAC-protected delivery route semantics.Description
build_status_data()so it only enumerates brief IDs; report bodies are no longer loaded into thebriefsmap insolvent/dashboard.py._sanitize_status_data()wrapper used by_refresh_status()and external status-file polling insolvent/server.pyto redactbriefsvalues (expose only IDs with empty values) before HTTP/SSE publishing.GET /api/briefs/{job_id}(added token parameter andverify_delivery_tokenguard) to match the canonical hosted brief route semantics insolvent/server.py.solvent/dashboard.py) to avoid rendering embedded brief text and to show a placeholder message directing users to the token-protected hosted brief link.tests/test_server.pyto assert status/dashboard pages do not disclose brief contents and that the preview API enforces delivery tokens.Testing
python -m py_compile solvent/dashboard.py solvent/server.py tests/test_server.pywhich succeeded.python -m unittest tests.test_server; tests executed in this environment but were skipped where thefastapitest client was not available (appropriate skip behavior), so headless client checks were not executed here.build_status_data()andrender()do not include the secret; this check passed.python -m unittest discover; this run surfaced unrelated environment/test-state failures (missing optionalrichdependency causing skipped tests and an unrelated test observing persisted jobs), indicating the failures are not caused by the dashboard redaction changes.Codex Task