Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 5.1 and added new generators (get/set) and option #3

Merged
merged 6 commits into from
Sep 7, 2015
Merged

Fixed 5.1 and added new generators (get/set) and option #3

merged 6 commits into from
Sep 7, 2015

Conversation

pionl
Copy link
Contributor

@pionl pionl commented Aug 15, 2015

Hi,

on laravel 5.1 the class and namespace was not replaced. I've replaced old name it with new names.

I've also added set and get generator (optional via -m or --getset), ignore option for ignoring specific tables and system tables (auth, migration and entrust package tables). Probably the system ignore should be in config.

Tested on laravel 5.1. The get and set output:

/**
 * @return mixed
 */
public function getName() {
    return $this->name;
}

/**
 * @param $value
 * @return $this
 */
public function setName($value) {
    $this->attributes["name"] = $value;
    return $this;
}

 /**
 * @param $value
 * @return $this
 */
public function setExternalId($value) {
    $this->attributes["external_id"] = $value;
    return $this;
}

First are getters then setters. The generation has tests.

Martin.

iberflow added a commit that referenced this pull request Sep 7, 2015
Fixed 5.1 and added new generators (get/set) and option
@iberflow iberflow merged commit 081be99 into iberflow:master Sep 7, 2015
@iberflow
Copy link
Owner

iberflow commented Oct 8, 2015

Hi Martin,
Thanks for the PR. I failed to test it before merging into the master, therefore there were a few issues in your update. I've fixed them with #5 so it should be all good now.

Thanks again!

@pionl
Copy link
Contributor Author

pionl commented Oct 12, 2015

Hi Ignas,
thank you for the info, i thought I've already send you the fixes. Sorry about that.

Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants