Twig Component follow ups #2792

mnocon · 2025-06-17T07:53:59Z

Target: 4.6, 5.0

Doc for:

github-actions · 2025-06-17T07:59:59Z

Preview of modified files

Preview of modified Markdown:

wiewiurdp · 2025-07-10T09:42:28Z

docs/templating/layout/customize_storefront_layout.md

+| `storefront-after-maincart` | `vendor/ibexa/storefront/src/bundle/Resources/views/themes/storefront/cart/component/maincart/maincart.html.twig` |
+| `storefront-before-minicart` | `vendor/ibexa/storefront/src/bundle/Resources/views/themes/storefront/cart/component/minicart/minicart.html.twig` |
+| `storefront-after-minicart` | `vendor/ibexa/storefront/src/bundle/Resources/views/themes/storefront/cart/component/minicart/minicart.html.twig` |
+| `storefront-before-add-to-cart` | `vendor/ibexa/cart/src/bundle/Resources/views/themes/standard/cart/component/add_to_cart/add_to_cart.html.twig` |


There would be a small change

storefront-before-add-to-cart
storefront-after-add-to-cart
storefront-before-summary
storefront-after-summary

these would be used in different templates see following PR
https://github.com/ibexa/storefront/pull/236

mnocon · 2025-07-10T13:49:06Z

Thank you @wiewiurdp , paths adjusted in bef9c6d

docs/templating/layout/customize_storefront_layout.md

Co-authored-by: julitafalcondusza <[email protected]>

github-actions · 2025-07-16T07:26:20Z

code_samples/ change report

Before (on target branch)	After (in current PR)
`code_samples/back_office/components/twig_components.yaml`	`code_samples/back_office/components/twig_components.yaml`
docs/templating/components.md@69:``` yaml `docs/templating/components.md@70:[[= include_file('code_samples/back_office/components/twig_components.yaml') =]]` docs/templating/components.md@71:```	docs/templating/components.md@73:``` yaml `docs/templating/components.md@74:[[= include_file('code_samples/back_office/components/twig_components.yaml') =]]` docs/templating/components.md@75:```
`001⫶ibexa_twig_components:` `002⫶ admin-ui-user-menu:` `003⫶ custom-html-component:` `004⫶ type: html`	`001⫶ibexa_twig_components:` `002⫶ admin-ui-user-menu:` `003⫶ custom-html-component:` `004⫶ type: html`
`005⫶ arguments:` `006⫶ content: '<b>Hello world!</b>'` `007⫶ custom-template-component:` `008⫶ type: template` `009⫶ arguments:` `010⫶ template: '@ibexadesign/ui/component/user_thumbnail/user_thumbnail.html.twig'` `011⫶ parameters:` `012⫶ user_content:` `013⫶ name: "Thumbnail"` `014⫶ thumbnail:` `015⫶ resource: https://placecats.com/100/100` `016⫶ custom-controller-component:` `017⫶ type: controller` `018⫶ arguments:` `019⫶ controller: '\App\Controller\MyController::requestAction'` `020⫶ parameters:` `021⫶ parameter1: 'custom'` `022⫶ parameter2: true` `023⫶ admin-ui-stylesheet-head:` `024⫶ custom-link-component:` `025⫶ type: stylesheet` `026⫶ arguments:` `027⫶ href: 'https://fonts.googleapis.com/css?family=Roboto:300,300i,400,400i,700,700i%7CRoboto+Mono:400,400i,700,700i&display=fallback'` `028⫶ rel: stylesheet` `029⫶ crossorigin: anonymous` `030⫶ integrity: sha384-LN/mLhO/GN6Ge8ZPvI7uRsZpiXmtSkep+aFlJcHa8by4TvA34o1am9sa88eUzKTD` `031⫶ type: text/css` `032⫶ admin-ui-script-head:` `033⫶ custom-script-component:` `034⫶ type: script` `035⫶ arguments:` `036⫶ src: 'https://doc.ibexa.co/en/latest/js/custom.js'` `037⫶ crossorigin: anonymous` `038⫶ defer: false` `039⫶ async: true` `040⫶ integrity: sha384-Ewi2bBDtPbbu4/+fs8sIbBJ3zVl0LDOSznfhFR/JBK+SzggdRdX8XQKauWmI9HH2` `041⫶ type: text/javascript`	`005⫶ priority: 0` `006⫶ arguments:` `007⫶ content: '<b>Hello world!</b>'` `008⫶ custom-template-component:` `009⫶ type: template` `010⫶ priority: 50` `011⫶ arguments:` `012⫶ template: '@ibexadesign/ui/component/user_thumbnail/user_thumbnail.html.twig'` `013⫶ parameters:` `014⫶ user_content:` `015⫶ name: "Thumbnail"` `016⫶ thumbnail:` `017⫶ resource: https://placecats.com/100/100` `018⫶ custom-controller-component:` `019⫶ type: controller` `020⫶ arguments:` `021⫶ controller: '\App\Controller\MyController::requestAction'` `022⫶ parameters:` `023⫶ parameter1: 'custom'` `024⫶ parameter2: true` `025⫶ admin-ui-stylesheet-head:` `026⫶ custom-link-component:` `027⫶ type: stylesheet` `028⫶ arguments:` `029⫶ href: 'https://fonts.googleapis.com/css?family=Roboto:300,300i,400,400i,700,700i%7CRoboto+Mono:400,400i,700,700i&display=fallback'` `030⫶ rel: stylesheet` `031⫶ crossorigin: anonymous` `032⫶ integrity: sha384-LN/mLhO/GN6Ge8ZPvI7uRsZpiXmtSkep+aFlJcHa8by4TvA34o1am9sa88eUzKTD` `033⫶ type: text/css` `034⫶ admin-ui-script-head:` `035⫶ custom-script-component:` `036⫶ type: script` `037⫶ arguments:` `038⫶ src: 'https://doc.ibexa.co/en/latest/js/custom.js'` `039⫶ crossorigin: anonymous` `040⫶ defer: false` `041⫶ async: true` `042⫶ integrity: sha384-Ewi2bBDtPbbu4/+fs8sIbBJ3zVl0LDOSznfhFR/JBK+SzggdRdX8XQKauWmI9HH2` `043⫶ type: text/javascript`

Download colorized diff

* Added Priority for YAML configuration * Added doc for storefront groups * Adjusted paths * Update docs/templating/layout/customize_storefront_layout.md Co-authored-by: julitafalcondusza <[email protected]> --------- Co-authored-by: julitafalcondusza <[email protected]>

* Added new Twig Component group (#2790) * Twig Component follow ups (#2792) * Added Priority for YAML configuration * Added doc for storefront groups * Adjusted paths * Update docs/templating/layout/customize_storefront_layout.md Co-authored-by: julitafalcondusza <[email protected]> --------- Co-authored-by: julitafalcondusza <[email protected]> * [Twig Components] Added Menu component (#2799) * Docs: Add Menu component to Twig Components documentation * Docs: Extend Twig Components YAML example with Menu component * Discounts 4.6.22 (#2810) * Adjusted code samples * [Discounts] Added doc for 4.6.22 * Fixed limit mention * Added update mention * Removed mentions of OverridePrioritatization * Wording * Update code_samples/discounts/src/Command/ManageDiscountsCommand.php Co-authored-by: Konrad Oboza <[email protected]> * Fixed highlights * Review suggestions * Added missing v prefix --------- Co-authored-by: Konrad Oboza <[email protected]> * IBX-9147: Symbol attribute type described in Developer Documentation - v4.6 (#2525) * Symbol attribute type described * Fixes after review * PHP CS Fixes * Resolved conflicts in product search criteria * Added composer dependency * fixes * review fixes * PHP & JS CS Fixes * symbol_attribute_type.md moved to Attributes folder * fixes; mysql added * fix in the table * fix --------- Co-authored-by: julitafalcondusza <[email protected]> Co-authored-by: Marek Nocoń <[email protected]> * Update 4.6.22 (#2851) * Adjusted code samples * [Discounts] Added doc for 4.6.22 * Fixed limit mention * Added update mention * Removed mentions of OverridePrioritatization * Wording * Update code_samples/discounts/src/Command/ManageDiscountsCommand.php Co-authored-by: Konrad Oboza <[email protected]> * Fixed highlights * Review suggestions * Added missing v prefix * Added doc for IBX-9933 * Fixed badge --------- Co-authored-by: Konrad Oboza <[email protected]> * IBX-9845: Solr9 (#2866) * Adjusted code samples * [Discounts] Added doc for 4.6.22 * Fixed limit mention * Added update mention * Removed mentions of OverridePrioritatization * Wording * Update code_samples/discounts/src/Command/ManageDiscountsCommand.php Co-authored-by: Konrad Oboza <[email protected]> * Fixed highlights * Review suggestions * Added missing v prefix * Described requirements * Added Solr 9 instructions * Fixed link * Updated instructions * Apply suggestions from code review Co-authored-by: julitafalcondusza <[email protected]> --------- Co-authored-by: Konrad Oboza <[email protected]> Co-authored-by: julitafalcondusza <[email protected]> * Release notes (#2869) * IBX-10262: Added mention of the renamed class * Release notes for 4.6.22 * Apply suggestions from code review Co-authored-by: julitafalcondusza <[email protected]> * Review fixes * Fixed link * Last minute fixes --------- Co-authored-by: julitafalcondusza <[email protected]> * Regenerated baseline * Removed bullet * Bumped latest tag * Added PHP API links * Added mention about Symbol attribute * Fixed link * Moved PHP API Symbol links * symbol_attribute_type.md: Link to PHP API Ref --------- Co-authored-by: julitafalcondusza <[email protected]> Co-authored-by: Konrad Oboza <[email protected]> Co-authored-by: julitafalcondusza <[email protected]> Co-authored-by: Adrien Dupuis <[email protected]>

Added Priority for YAML configuration

a91c974

Added doc for storefront groups

b3f176a

mnocon requested a review from wiewiurdp July 3, 2025 12:50

mnocon added the Needs DEV review label Jul 3, 2025

wiewiurdp requested changes Jul 10, 2025

View reviewed changes

Adjusted paths

bef9c6d

mnocon requested a review from wiewiurdp July 10, 2025 13:49

wiewiurdp approved these changes Jul 10, 2025

View reviewed changes

mnocon added Needs DOC review and removed Needs DEV review labels Jul 15, 2025

mnocon requested a review from a team July 15, 2025 09:31

ezrobot requested review from adriendupuis, dabrt and julitafalcondusza and removed request for a team July 15, 2025 09:31

julitafalcondusza approved these changes Jul 16, 2025

View reviewed changes

docs/templating/layout/customize_storefront_layout.md Outdated Show resolved Hide resolved

Update docs/templating/layout/customize_storefront_layout.md

223368b

Co-authored-by: julitafalcondusza <[email protected]>

mnocon added Wait with merge PRs that shouldn't be merged instantly Ready for MERGE and removed Needs DOC review labels Jul 16, 2025

mnocon changed the base branch from 4.6 to release-4.6.22 August 5, 2025 11:10

mnocon merged commit dbe9d5c into release-4.6.22 Aug 5, 2025
7 checks passed

mnocon deleted the twig-component-follow-ups branch August 5, 2025 11:11

mnocon mentioned this pull request Aug 5, 2025

Release 4.6.22 #2867

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Twig Component follow ups #2792

Twig Component follow ups #2792

Uh oh!

mnocon commented Jun 17, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 17, 2025 •

edited

Loading

Uh oh!

wiewiurdp Jul 10, 2025

Uh oh!

mnocon commented Jul 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Jul 16, 2025

Uh oh!

Uh oh!

Uh oh!

Twig Component follow ups #2792

Twig Component follow ups #2792

Uh oh!

Conversation

mnocon commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Preview of modified files

Uh oh!

wiewiurdp Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

mnocon commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 16, 2025

code_samples/ change report

Uh oh!

Uh oh!

Uh oh!

mnocon commented Jun 17, 2025 •

edited

Loading

github-actions bot commented Jun 17, 2025 •

edited

Loading

mnocon commented Jul 10, 2025 •

edited

Loading