IBX-8471: [Browser tests] Made APP_SECRET longer for JWT
#62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradoboza
approved these changes
May 16, 2025
tomaszszopinski
approved these changes
May 16, 2025
ciastektk
approved these changes
May 16, 2025
micszo
approved these changes
May 16, 2025
ViniTou
approved these changes
May 16, 2025
KamilSznajdrowicz
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
APP_SECRETfor Behat tests #61Description:
Looks like
APP_SECRETneeds to be longer for JWT to work properly.Too short
APP_SECRETcauses this PB issue.My local tests show that 32 characters is enough [1], but following the issue linked above, I've made it 64 just to be safe.
[1] That's why I couldn't reproduce it locally.
For QA:
Occurs only for regression tests setup.