IBX-10705: Updated vcl to fix caching in dev env and re-enable symfony profiler #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezrobot
requested review from
adamwojs,
mikadamczyk,
Steveb-p,
alongosz,
ciastektk,
ViniTou,
barw4,
wiewiurdp,
konradoboza and
tbialcz
and removed request for
a team
Sztig
force-pushed
the
IBX-10705-v5-varnish-profiler-fix
branch
from
967945c to
68e9664
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
As mentioned in the public ticket itself, Varnish fails to cache any content in
devenv because the application sends profiler-related Set-Cookie headers, this change was introduced in 7.3 insecurity-bundlepackage.I've updated VCL files to bring varnish and symfonys profiler back to working order.
The fix is up to debate, during the tests with @reithor and @vidarl we didn't discover any breaking issue.