Skip to content

IBX-8471: [Composer] Dropped conflict with mink-browserkit-driver v1.6.2 #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented May 12, 2025

Caution

  • Drop TMP commit before merging
🎫 Issue IBX-8471

Related PRs:

Description:

Reverting conflict added via #136 for 3.3.

Seems GoutteDriver was dropped via ibexa/behat#130, so maybe it's enough to remove that conflict now?
We need v1.6.2 as this is the only tag supporting Symfony 7.

Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point we need to.

@alongosz
Copy link
Member Author

I suggest merging this as-is to unblock PRs resolving other issues. The issue at hand was resolved, but there's more regressions to work on.

@alongosz alongosz marked this pull request as ready for review May 12, 2025 14:45
@adamwojs adamwojs merged commit 1a5726f into master May 12, 2025
6 of 18 checks passed
@adamwojs adamwojs deleted the drop-conflict-with-browserkit-1.6.2 branch May 12, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants