Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bigquery): allow sane use of params with raw_sql #10874

Merged
merged 1 commit into from
Feb 20, 2025
Merged

fix(bigquery): allow sane use of params with raw_sql #10874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions ibis/backends/bigquery/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,15 +663,7 @@ def _get_schema_using_query(self, query: str) -> sch.Schema:

def raw_sql(self, query: str, params=None, page_size: int | None = None):
query_parameters = [
bigquery_param(
param.type(),
value,
(
param.get_name()
if not isinstance(op := param.op(), ops.Alias)
else op.arg.name
),
)
bigquery_param(param.type(), value, param.get_name())
for param, value in (params or {}).items()
]
with contextlib.suppress(AttributeError):
Expand Down
9 changes: 9 additions & 0 deletions ibis/backends/bigquery/tests/system/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,3 +496,12 @@ def test_geom_from_pyarrow(con, monkeypatch):
assert len(t.to_pandas()) == 2
finally:
con.drop_table(name)


def test_raw_sql_params_with_alias(con):
name = "cutoff"
cutoff = ibis.param("date").name(name)
value = datetime.date(2024, 10, 28)
query_parameters = {cutoff: value}
result = con.raw_sql(f"SELECT @{name} AS {name}", params=query_parameters)
assert list(map(dict, result)) == [{name: value}]
Loading