1050: Fix coredump on PCIe Topology Refresh (#1307) #1309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to improper lambda capture `&req` [1], its reference inside the
async_method_call later may potentially become invalid if `req` is
already removed. This may cause the coredump of bmcweb at
````
BMCWEB_LOG_DEBUG << "Set PCIe Topology Refresh status.";
crow::connections::systemBus->async_method_call(
[&req, aResp](const boost::system::error_code ec) {
...
pcieTopologyRefreshTimer =
std::make_unique<boost::asio::steady_timer>(*req.ioService);
...
```
The fix is to capture `req` as value so that `req` should be valid
inside the callback.
```
- [&req, asyncResp](const boost::system::error_code& ec) {
+ [req, asyncResp](const boost::system::error_code& ec) {
```
Tested:
- Try setPCIeTopologRefresh multiple times without coredumps
```
curl -k -H "Content-Type: application/json" -X PATCH https://${bmc}/redfish/v1/Systems/system/ -d '{"Oem":{"IBM":{"PCIeTopologyRefresh":true}}}'
```
[1] https://github.com/ibm-openbmc/bmcweb/blob/2a42b4b15776e5f6e4777b856c59d0e5c34c7f1e/redfish-core/lib/oem/ibm/pcie_topology_refresh.hpp#L108
Signed-off-by: Myung Bae <[email protected]>
|
jenkins run tests please |
baemyung
approved these changes
Jun 9, 2025
|
jenkins run tests please |
1 similar comment
|
jenkins run tests please |
|
I think this can be canceled as the fix was already merged - 12dde3f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix coredump on PCIe Topology Refresh (#1307)
curl -k -H "Content-Type: application/json" -X PATCH https://${bmc}/redfish/v1/Systems/system/ -d '{"Oem":{"IBM":{"PCIeTopologyRefresh":true}}}'