Spdm tcp responder schema #90
Conversation
|
Can one of the admins verify this patch? |
|
Since this design doc was merged are you able to just do this upstream? |
I am looking for the initial review and approval in downstream, after that I will push it upstream. |
|
From an EM perspective, it looks fine (maybe capitalize all the acronyms), so I'll leave to others for if it holds all the right stuff. |
schemas/spdm.json
Outdated
| "Type": { | ||
| "description": "The type of spdm tcp responder", | ||
| "enum": ["Responder"] | ||
| } |
There was a problem hiding this comment.
What does Type of TCP Responder mean ? we only plan on supporting SpdmTcpResponder, Is this sort of a default that we need to have ?
There was a problem hiding this comment.
As show for example here, https://github.com/openbmc/entity-manager/blob/master/configurations/rainier_4u_chassis.json#L19, EM builds up the interface name on the fly as xyz.openbmc_project.Configuration.<Type>.
So I guess actually here you'd need the type to be SpdmTcpResonder.
schemas/spdm.json
Outdated
| "required": ["Hostname", "Port", "Type"] | ||
| } |
There was a problem hiding this comment.
@spinler - the Interface name will be SpdmTcpResponder with that in context do we really need another property called Type - which is hardcoded to Responder ?
|
You would get better discussion upstream, but my opinion is that entity-manager represents hardware, even networking hardware. so it makes an inventory object for that piece of networking hardware, and then on that it exposes the SPDM configuration. |
This schema will be utilized to add SPDM Tcp Responders to the user system. More information on SPDM Tcp Responder can be found at [1]. Tested: - Confirmed a system utilizing new schema worked as expected [1]: https://github.com/openbmc/docs/blob/master/designs/redfish-spdm-attestation.md Signed-off-by: Archana Kakani <[email protected]>
ArchanaKakani
force-pushed
the
SPDMTCPResponderSchema1120
branch
from
d3ddeb6 to
c447d63
Compare
4 participants
This schema will be utilized to add SPDM Tcp Responders to the user system.
More information on SPDM Tcp Responder can be found at 1.
Tested: