Update monitorwaited01 and VThreadEventTest to work with OpenJ9 #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenJ9 has its own implementation of virtual threads in the JVM. Due to differences in implementation, the monitorwaited01 and VThreadEventTest tests have been updated to check the function names used in OpenJ9's virtual thread implementation. Related: eclipse-openj9/openj9#19191 Related: eclipse-openj9/openj9#20707 Signed-off-by: Babneet Singh <[email protected]>
|
@fengxue-IS Can you do an initial review? @tajila Can you review and merge after @fengxue-IS's review? This PR fixes two JDK24 failures:
These changes are backported to JDK24 via ibmruntimes/openj9-openjdk-jdk24#22. |
This was referenced Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenJ9 has its own implementation of virtual threads in the JVM.
Due to differences in implementation, the
monitorwaited01andVThreadEventTesttests have been updated to check the function namesused in OpenJ9's virtual thread implementation.
Related: eclipse-openj9/openj9#19191
Related: eclipse-openj9/openj9#20707