test: verify Docker image builds and starts successfully on custom ports#347
test: verify Docker image builds and starts successfully on custom ports#347icebear0828 wants to merge 1 commit intomasterfrom
Conversation
Modifies the Docker smoke test workflow (`ci-docker.yml`) to use a strategy matrix that runs the container on both the default port `8080` and a custom port `8090`. The `docker-healthcheck.sh` script is simultaneously updated to dynamically resolve the required port using the injected `PORT` environment variable, falling back gracefully to local overlays, default config, or `8080`. Fixes #120 Co-authored-by: icebear0828 <63769498+icebear0828@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR addresses the issue of verifying the Docker image builds and executes the health checks correctly on alternate ports.
Changes introduced:
.github/workflows/ci-docker.ymltesting both8080and8090.-e PORT=${{ matrix.port }}argument.docker runto match the matrix target.18080.docker-healthcheck.shto prioritize the injectedPORTenv variable forcurlconnectivity before reading local config or default overrides.PR created automatically by Jules for task 13855028842721639643 started by @icebear0828